Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: v6, item padding adds additional spacing to bottom #23892

Closed
4 of 6 tasks
rdlabo opened this issue Sep 8, 2021 · 2 comments
Closed
4 of 6 tasks

bug: v6, item padding adds additional spacing to bottom #23892

rdlabo opened this issue Sep 8, 2021 · 2 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report v6 issues specific to Framework v6

Comments

@rdlabo
Copy link
Contributor

rdlabo commented Sep 8, 2021

Prequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

ion-item {
  --padding-top: 20px;
  --background: red;
}

--padding-top of this css is not work like v4 - 5. If --padding-** is deprecated and recommend --padding-inner-**, we should write break changes.

スクリーンショット 2021-09-08 午後11 34 14

Thanks.

Expected Behavior

スクリーンショット 2021-09-08 午後11 34 32

Steps to Reproduce

File is here:
https://github.com/rdlabo/ionic-v6-suggest/pull/1/files

And hosted with netlify:

https://deploy-preview-1--sharp-varahamihira-473c70.netlify.app/

Code Reproduction URL

No response

Ionic Info

Ionic:

Ionic CLI : 6.16.3 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.0.0-beta.5
@angular-devkit/build-angular : 12.1.4
@angular-devkit/schematics : 12.1.4
@angular/cli : 12.1.4
@ionic/angular-toolkit : 4.0.0

Utility:

cordova-res (update available: 0.15.3) : 0.11.0
native-run (update available: 1.4.1) : 1.3.0

System:

NodeJS : v14.16.0 (/usr/local/bin/node)
npm : 6.14.11
OS : macOS Big Sur

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Sep 8, 2021
@liamdebeasi liamdebeasi changed the title bug: --padding is not padding at item bug: v6, item padding added additional spacing to bottom Sep 8, 2021
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report v6 issues specific to Framework v6 labels Sep 8, 2021
@ionitron-bot ionitron-bot bot removed triage labels Sep 8, 2021
@liamdebeasi liamdebeasi changed the title bug: v6, item padding added additional spacing to bottom bug: v6, item padding adds additional spacing to bottom Sep 8, 2021
sean-perkins added a commit that referenced this issue Dec 8, 2021
* fix(item): remove empty padding space for item bottom

* test(item): padding CSS variable screenshot test

* fix(item): remove --bottom-padding-start CSS variable

Resolves #23892
@sean-perkins
Copy link
Contributor

@rdlabo thanks for reporting this issue.

This has been fixed and will be available in the next release of Ionic 6 (6.0.1 and later).

@ionitron-bot
Copy link

ionitron-bot bot commented Jan 7, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report v6 issues specific to Framework v6
Projects
None yet
Development

No branches or pull requests

3 participants