Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Material design implementation for counter display with ion-item #24334

Closed
4 of 6 tasks
sean-perkins opened this issue Dec 6, 2021 · 1 comment · Fixed by #24335
Closed
4 of 6 tasks

bug: Material design implementation for counter display with ion-item #24334

sean-perkins opened this issue Dec 6, 2021 · 1 comment · Fixed by #24335
Labels
package: core @ionic/core package type: bug a confirmed bug report v6 issues specific to Framework v6

Comments

@sean-perkins
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

The counter implementation with ion-item is incorrect with the Material Design Spec: https://material.io/components/text-fields.

Expected Behavior

The counter should have the following changes:

  • Text should be formatted with a space between the counts: 5 / 10 instead of 5/10 (related to feat: counterFormatter for counter string in ion-item #24327)
  • Text color should be rgba(0, 0, 0, .6)
  • Text letter spacing should be 0.0333333em
  • The counter should always push contents to appear right-aligned
  • The counter should have 16px of padding between itself and the contents to the left (in LTR)

Steps to Reproduce

Have an item implementation using v6 with the counter feature:

<ion-input [counter]="true">
   <ion-label position="stacked">Label</ion-label>
   <ion-input maxlength="20"></ion-input>
</ion-input>

Compare to the live example from the Material Design spec.

Code Reproduction URL

https://codesandbox.io/s/prod-frog-eymwq?file=/src/app/app.component.html

Ionic Info

No response

Additional Information

No response

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 18, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report v6 issues specific to Framework v6
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant