-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: ion-datetime not changing class 'calendar-day-active' when clicking a date #24414
Comments
Thanks for the issue! This issue has been labeled as Please reproduce this issue in an Ionic starter application and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed. If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue. For a guide on how to create a good reproduction, see our Contributing Guide. |
I am facing same problem on iphone, ios version 15.2 |
I can reproduce this issue as well on Edge and Chrome on an intel 2020 Macbook. It only happens for me when the I am seeing this behavior when using |
@Ionitron I added a code snippet for reproduction |
experienced the same thing with other weird behaviors, reported #24451 |
Hello everyone! Thanks for reporting this issue, adding additional details and helping isolate the driving factors contributing to the bug. I have an open PR to address this issue (and other mentioned issue): #24454 Unfortunately I am the one that introduced this bug when fixing another issue (programmatically setting the value wasn't updating the date picker display) 🪦. I want to write a few more tests later today to validate the previous (expected) behaviors as well as the patched fixes. If all that goes well, I'll post a dev build for everyone to test with. With the holiday cycle, we won't be publishing |
If anyone that is available would like to also additionally confirm this resolution, I'd appreciate it 👍 npm install @ionic/[email protected] |
@sean-perkins I have tested this locally with |
@brinehart thanks for testing this! Did you happen to install the dependency for both Here's a test repository to confirm:
|
FYI. I have tested OK (both android and ios) using: |
@sean-perkins Tried it, but didn't work. npm list: |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
Current Behavior
It happens when I use the ion-datetime in a modal and when showDefaultButtons=true.
In browser and on android phone:
When I select a date, the class 'calendar-day-active' doesn't change to the selected date.
The only thing that happens when I select a date is that the :focus styling applies. (I selected 17. in this example)
EDIT: The behavior for browser and android seems to be normal, it just feels odd to me. Because when I click a date, I expect it to change the active styling and when i press 'Done' i want the value to be written to my variable.
On iOS:
The selected date doesn't change styling at all. Not even the focused styling gets applied.
After i clicked 15. the value is set to my variable, but it is not visible.
Expected Behavior
When I click on a date, I expect it to have the active styling.
Steps to Reproduce
Code Snippet
Ionic Info
Ionic:
Ionic CLI : 6.16.3 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.0.0
@angular-devkit/build-angular : 12.1.4
@angular-devkit/schematics : 12.1.4
@angular/cli : 12.1.4
@ionic/angular-toolkit : 4.0.0
Capacitor:
Capacitor CLI : 3.1.2
@capacitor/android : 3.2.4
@capacitor/core : 3.2.4
@capacitor/ios : 3.2.4
Utility:
cordova-res : not installed globally
native-run (update available: 1.5.0) : 1.4.0
System:
NodeJS : v14.15.3 (/usr/local/bin/node)
npm : 6.14.9
OS : macOS Catalina
Additional Information
No response
The text was updated successfully, but these errors were encountered: