Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): update active day styling when day is selected #24454

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Dec 21, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Selecting a new day value in the calendar will update the local value, but will not update the visual "active day" of the calendar.

Issue Number: Resolves #24414, #24451

What is the new behavior?

When a new day value is selected, the active day will render correctly.

  • The activePartsClone which is used for the isActive calculation, is now updated with the value of the activeParts new value.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Introduced in #24414

Before After
Kapture.2021-12-22.at.11.56.52.mp4
Kapture.2021-12-22.at.11.55.15.mp4

@sean-perkins sean-perkins requested a review from a team as a code owner December 21, 2021 05:29
@github-actions github-actions bot added the package: core @ionic/core package label Dec 21, 2021
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to use a @Watch (https://stenciljs.com/docs/reactive-data#watch-decorator) on activeParts to make sure activePartsClone stays updated? That way you wouldn't have to worry about it in so many places.

@sean-perkins
Copy link
Contributor Author

Would it make sense to use a @Watch (https://stenciljs.com/docs/reactive-data#watch-decorator) on activeParts to make sure activePartsClone stays updated? That way you wouldn't have to worry about it in so many places.

The @Watch approach was much more streamlined, thanks for the suggestion! 👍

Test has been added to validate that setting the active day updates the active day (in the same month).

Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-datetime not changing class 'calendar-day-active' when clicking a date
2 participants