Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: router-outlet should activate a route with the same components if params are different #24653

Closed
4 of 6 tasks
vicb opened this issue Jan 25, 2022 · 2 comments · Fixed by #24760
Closed
4 of 6 tasks
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@vicb
Copy link
Contributor

vicb commented Jan 25, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

It is not possible to load a route with the same component in the outlet even if the params are different.

That's because we only compare the component, not the params.

Expected Behavior

It should be possible to load a route with the same component as long as the params are different.

This would be consistent with <ion-nav>

Steps to Reproduce

Activate routes with the same component and different params.

I'll send a PR with tests.

Code Reproduction URL

No response

Ionic Info

No response

Additional Information

#24652 needs to be fixed first

@ionitron-bot ionitron-bot bot added the triage label Jan 25, 2022
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Jan 27, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jan 27, 2022
liamdebeasi pushed a commit that referenced this issue Feb 11, 2022
@liamdebeasi
Copy link
Contributor

Resolved via #24760

@ionitron-bot
Copy link

ionitron-bot bot commented Mar 13, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants