Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-outlet): add ability to active the same component. #24760

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 9, 2022

It it possible to activate the same component as long as parameters are different to match the behavior of

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

If 2 routes share the same component and the first is active, the router outlet will not allow activating the second even if the parameters are differents

Issue Number: fixes #24653

What is the new behavior?

A route route using the same component as the current one can be activated as long as parameters are differents.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vicb vicb requested a review from a team as a code owner February 9, 2022 19:03
@github-actions github-actions bot added the package: core @ionic/core package label Feb 9, 2022
It it possible to activate the same component as long as parameters are different to match the behavior of <ion-nav>
@sean-perkins sean-perkins requested a review from a team February 9, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: router-outlet should activate a route with the same components if params are different
4 participants