Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance keyboard input support on web for ion-datetime #25555

Closed
3 tasks done
klscmms opened this issue Jun 29, 2022 · 4 comments
Closed
3 tasks done

feat: enhance keyboard input support on web for ion-datetime #25555

klscmms opened this issue Jun 29, 2022 · 4 comments
Labels
needs: reply the issue needs a response from the user

Comments

@klscmms
Copy link

klscmms commented Jun 29, 2022

Prerequisites

Describe the Feature Request

Based on the Issue 23768 and the related PR. It will be nice to make the keyboard input at the time picker more intuitive.

For now, if I open the time picker on the calendar, the time picker won't have any responses with the keyboard input. The keyboard input only works if I first click the time(hour or min) and click space in the time picker modal. If I click on the time, it can only change the value by scrolling.

Describe the Use Case

It will be nice to support the keyboard input when the modal opens.

Describe Preferred Solution

No response

Describe Alternatives

No response

Related Code

No response

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Jun 29, 2022
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you provide a GitHub repo I can use to verify this behavior? The time picker should accept keyboard input (up/down arrow keys).

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Jun 29, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jun 29, 2022
@klscmms
Copy link
Author

klscmms commented Jun 30, 2022

Thanks for the issue. Can you provide a GitHub repo I can use to verify this behavior? The time picker should accept keyboard input (up/down arrow keys).

The latest ionic version can reproduce the behaviour.
The up/down keys work, but can it also support number input as well?

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Jun 30, 2022
@liamdebeasi
Copy link
Contributor

Can you provide a GitHub repo with steps to reproduce? I am not able to reproduce the issue on my end.

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Jun 30, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jun 30, 2022
@ionitron-bot
Copy link

ionitron-bot bot commented Jul 14, 2022

Thanks for the issue! This issue is being closed due to the lack of a reply. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!

@ionitron-bot ionitron-bot bot closed this as completed Jul 14, 2022
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

2 participants