fix(datetime): time picker uses new iOS 15 style #23996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averyjohnston
suggested changes
Oct 4, 2021
| } | ||
|
|
||
| export const getFormattedTime = (refParts: DatetimeParts, use24Hour: boolean): string => { | ||
| if (refParts.hour === undefined || refParts.minute === undefined) { return 'Invalid Time'; } |
There was a problem hiding this comment.
Should this also warn if the user tries to pass a logistically invalid time, like 25 for the hour?
There was a problem hiding this comment.
We could, but the refParts that gets passed in is created via users selecting options in datetime that we create so there's no user generated content there. I believe datetime will error out if you pass in an invalid ISO 8601 string into the value field for user generated content. I can add a check if you think it would be valuable though.
There was a problem hiding this comment.
Nah, if the only way to enter a custom time is through an ISO string, we should be good 👍 Just wanted to make sure.
averyjohnston
approved these changes
Oct 4, 2021
willmartian
approved these changes
Oct 5, 2021
3 tasks
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #23768
What is the new behavior?
Does this introduce a breaking change?
Other information