fix(refresher): refresher is visible with multiple custom scroll targets #25750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When using refresher with multiple instances of CDK virtual scroll and custom scroll target definitions, the pull to refresh behavior will trigger, but the refresher content will not be visible.
This was due to the background content element resolving as
null
, instead of theion-content
's background content element. This behavior seems to be derived from the refresher being slotted into the light DOM and the parent element not being fully rendered when the connected callback fires for the refresher.Issue URL: #25495
What is the new behavior?
ion-content
element to be ready, before querying the scroll and background content element.ion-content
for querying the background content elementDoes this introduce a breaking change?
Other information
Dev-build:
6.2.2-dev.11660183625.1a3e60c7
.