Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refresher): refresher is visible with multiple custom scroll targets #25750

Merged
merged 5 commits into from
Aug 15, 2022

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Aug 11, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When using refresher with multiple instances of CDK virtual scroll and custom scroll target definitions, the pull to refresh behavior will trigger, but the refresher content will not be visible.

This was due to the background content element resolving as null, instead of the ion-content's background content element. This behavior seems to be derived from the refresher being slotted into the light DOM and the parent element not being fully rendered when the connected callback fires for the refresher.

Issue URL: #25495

What is the new behavior?

  • Refresher will wait for the parent ion-content element to be ready, before querying the scroll and background content element.
  • Introduces an internal API to ion-content for querying the background content element

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.2.2-dev.11660183625.1a3e60c7.

@github-actions github-actions bot added the package: core @ionic/core package label Aug 11, 2022
@sean-perkins sean-perkins marked this pull request as ready for review August 11, 2022 02:34
@sean-perkins sean-perkins requested a review from a team as a code owner August 11, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants