Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): loading layout is correct with no message #26222

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

bipoza
Copy link
Contributor

@bipoza bipoza commented Nov 3, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

resolves #26219

Loading only renders the message content when message !== undefined. Since useIonLoading defaulted the message to '', the message content was always being rendered causing extra spacing to be added.

useIonLoading bug

Also, if the spinner parameter is not defined, the spinner "lines" is always set by default.

In this case, in my opinion it is more appropriate not to condition it in the hook and let the core component choose which layout to use for each platform.

Issue URL: resolves #26219

What is the new behavior?

  • useIonLoading now defaults the message property to empty object.
  • The default spinner of useIonLoading hook will be chosen in the core.
android_example.mov
ios_example.mov

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bipoza bipoza requested a review from a team as a code owner November 3, 2022 14:51
@github-actions github-actions bot added the package: react @ionic/react package label Nov 3, 2022
@liamdebeasi liamdebeasi self-requested a review November 3, 2022 14:55
@liamdebeasi liamdebeasi requested a review from a team November 3, 2022 15:26
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@sean-perkins sean-perkins merged commit 57105d5 into ionic-team:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: useIonLoading, message container is always rendered even when not using a message
3 participants