fix(react): loading layout is correct with no message #26222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
resolves #26219
Loading only renders the message content when message !== undefined. Since useIonLoading defaulted the message to '', the message content was always being rendered causing extra spacing to be added.
Also, if the spinner parameter is not defined, the spinner "lines" is always set by default.
In this case, in my opinion it is more appropriate not to condition it in the hook and let the core component choose which layout to use for each platform.
Issue URL: resolves #26219
What is the new behavior?
android_example.mov
ios_example.mov
Does this introduce a breaking change?
Other information