Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reorder): items animate once in firefox #26326

Merged
merged 4 commits into from
Nov 22, 2022
Merged

fix(reorder): items animate once in firefox #26326

merged 4 commits into from
Nov 22, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 21, 2022

⚠️ Give co-author credit to https://github.com/dan-rp1 when merging.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #21182

What is the new behavior?

  • Ensures that the DOM is manipulated and the styles are changed in a same frame.
  • I also changed the change of "completeSync" to "completeReorder" since this function is no longer sync.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 21, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 21, 2022 15:55
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 21, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: IonReorder items animate twice in Firefox
2 participants