bug: datetime, cannot entry 00 for time entry

[iStoha]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Ionic Framework Version

• v4.x
• v5.x
• v6.x
• Nightly

Current Behavior

When clicking on time picker trying to change time a number keypad opens on mobile phone but you can change the hour value to everything but 00 for some reason. I can change minutes to 00 for some of the times.

Untitled.mp4

Expected Behavior

00 shoud be an expected value for hour or minutes field when entering via a keypad just like any other numbers.
for e.g 00:00 ( Not alllowed via keypad. )

Steps to Reproduce

Steps to Reproduce

Android

• Use ion-datetime and generate the apk using cordova.
• Click on the hour column or minute column to open the numeric keyboard in phone.
• Enter 00 from keypad and the value is not accepted while other numbers can be entered.

You can observe the same behaviour on browsers using the keyboard.

https://angular-yxrjrr.stackblitz.io

Code Reproduction URL

https://github.com/iStoha/time-picker

Ionic Info

Ionic:

Ionic CLI : 5.4.13
Ionic Framework : @ionic/angular 13.2.2
@angular-devkit/build-angular : 13.2.2
@angular-devkit/schematics : 13.2.2
@angular/cli : 13.2.2
@ionic/angular-toolkit : 6.0.0

Cordova:

Cordova CLI : 11.0.0
Cordova Platforms : android 9.1.0
Cordova Plugins : cordova-plugin-ionic-keyboard , cordova-plugin-ionic-webview (and other plugins)

Additional Information

No response

[liamdebeasi]

Thanks for the report. I can reproduce this behavior. We use a regex to clean up the wheel picker values when trying to best match your keyboard entry to an item in the wheel. The regex does this by stripping out leading zeros. This allows you to type '2' and get '02' selected without having to type the leading zero. This regex had a flaw where it stripped all leading zeros from a string, including when the string was only zeros (i.e '00'). As a result, your entry of '0' never matched '00'.

I fixed this by having the regex allow at least one 0 when the string it was processing was all zeros. As a result, '00' becomes '0' and will now match your keyboard entry of '0'.

Here is a dev build if you would like to test the proposed fix:

6.3.10-dev.11670337426.126ffd2c

[iStoha]

@liamdebeasi I am sorry if i sound out of depth here.
How would i go about testing this dev build 6.3.10-dev.11670337426.126ffd2c ?
Where can i find it?

[liamdebeasi]

No worries, I should have provided more instructions. That dev build points to a pre-release version of Ionic on npm that contains the fix for this issue. You can run the following command to install it:

npm install @ionic/[email protected]

(This dev build also works for other packages such as @ionic/react too)

[iStoha]

Hi @liamdebeasi
I just tested. It is working now. Thanks a lot!

[liamdebeasi]

Thanks for the issue. This has been resolved via #26423, and a fix will be available in an upcoming release of Ionic Framework.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.