Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Problem when changing button's color and style #6202

Closed
iignatov opened this issue Apr 17, 2016 · 6 comments
Closed

bug: Problem when changing button's color and style #6202

iignatov opened this issue Apr 17, 2016 · 6 comments
Assignees
Milestone

Comments

@iignatov
Copy link
Contributor

Short description of the problem:

When setting the color and style attributes of the button programmatically, the changes are not applied/visualized as expected.

What behavior are you expecting?

The changes to color and style attributes should be visualized as they are set in the code.

Steps to reproduce:

  1. Open http://plnkr.co/edit/2fViim?p=preview
  2. Click the button [Unify all buttons].
  3. Observe that not all buttons are set to the default state.

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

Which Ionic Version? 2.x

Plunker that shows an example of your issue

http://plnkr.co/edit/2fViim?p=preview

Run ionic info from terminal/cmd prompt: (paste output below)

Your system information:

Cordova CLI: 6.1.1
Gulp version:  CLI version 1.2.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.4
Ionic CLI Version: 2.0.0-beta.24
Ionic App Lib Version: 2.0.0-beta.14
OS: Windows 8.1
Node Version: v5.8.0
@TechWithRamaa
Copy link

Quit your Ionic CLI and run again. Or restart the browser. It must be due to invalid reassignment of values to variables that alter the color of the buttons during Stack refresh.

@arielweinberger
Copy link

If you create a dummy element, say a <h1>, attach a class to it and change a property via CSS. Do the changes apply?

@arielweinberger
Copy link

Also, if you attach a class to the button, sometihng like button-assertive do the changes apply?

@iignatov
Copy link
Contributor Author

@RAMDdFLEET @Frightie Maybe I didn't write a good/clear description - the problem is when both color and style attributes are updated at once. You can observe it in this plunker demo following the repro-steps. Thank you for the suggestions, but I already implemented a fix that should resolve the issue.

@brandyscarney brandyscarney added this to the 2.0.0-beta.6 milestone Apr 20, 2016
@brandyscarney brandyscarney self-assigned this Apr 20, 2016
brandyscarney added a commit that referenced this issue Apr 27, 2016
This prevents `button-solid-secondary` from being added when it should
just be `button-secondary`.

references #6202
brandyscarney added a commit that referenced this issue Apr 27, 2016
updated tests to include toolbar with solid buttons and bar buttons in
karma tests.

references #6202
@brandyscarney
Copy link
Member

Thank you @iignatov for the PR! This will be in the beta.7 release. 😄

@iignatov
Copy link
Contributor Author

@brandyscarney Great, thanks for the update!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants