-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popover): popover can now be used inline #23231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: angular
@ionic/angular package
package: core
@ionic/core package
package: react
@ionic/react package
package: vue
@ionic/vue package
labels
Apr 23, 2021
willmartian
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really solid! Great work.
brandyscarney
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: angular
@ionic/angular package
package: core
@ionic/core package
package: react
@ionic/react package
package: vue
@ionic/vue package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information
In order for slots to work properly across framework integrations,
ion-popover
needs to be converted to shadow. As a result, I exposed a few shadow parts so that users can still style certain internals.More robust documentation and usage examples will be added in the desktop popover PR. I wanted to split the inline popover feature out to its own PR to make it easier to review. I will be doing the same thing for
ion-modal
after popover is done in prep for ourion-datetime
work.A few notes on things I added:
isOpen
property is used in Ionic Vue and Ionic React to programmatically open/close a popover. I moved it to the core component so that Angular and Vanilla JS users can use this feature as well.willPresent
,didPresent
,willDismiss
, anddidDismiss
events are shorthands used in Ionic Vue and Ionic React so devs don't need to keep writingionPopover
every time they want to listen for a popover lifecycle event. I moved those to the core component too so that Angular and Vanilla JS users can use these as well.The above 2 notes also help reduce the amount of framework-specific code we need to write an maintain.
ion-popover
inline, the framework takes care of rendering it, so the popover is already created within the JS Framework's application context. Framework delegates are still needed forpopoverController
since those are initially created outside of the JS Framework's app context.