Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(modal): document stacked modal behavior #23279

Merged
merged 2 commits into from
May 7, 2021
Merged

docs(modal): document stacked modal behavior #23279

merged 2 commits into from
May 7, 2021

Conversation

bitflower
Copy link
Contributor

@bitflower bitflower commented May 6, 2021 •
edited
Loading

As discussed with @liamdebeasi ;-) Hope it makes sense!

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bitflower
Explain stacked modals with different size
3b2080d 
As discussed with @liamdebeasi  ;-) Hope it  makes sense!
@github-actions github-actions bot added the package: core @ionic/core package label May 6, 2021
@bitflower bitflower mentioned this pull request May 6, 2021
Closed
@bitflower bitflower changed the title Explain stacked modals with different size [docs only] Explain stacked modals with different size May 6, 2021
liamdebeasi
liamdebeasi reviewed May 7, 2021
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I suggested some changes for clarity, but otherwise this looks great.

core/src/components/modal/readme.md Outdated Show resolved Hide resolved
@liamdebeasi liamdebeasi changed the title [docs only] Explain stacked modals with different size docs(modal): document stacked modal behavior May 7, 2021
@liamdebeasi liamdebeasi merged commit f36eabc into ionic-team:master May 7, 2021
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lodenrogue lodenrogue lodenrogue approved these changes

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitflower @liamdebeasi @lodenrogue