Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datetime): add time picker #23353

Merged
merged 56 commits into from
May 24, 2021
Merged

feat(datetime): add time picker #23353

merged 56 commits into from
May 24, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Part of the Framework v6 datetime work

What is the new behavior?

  • Added time picker on iOS and MD including keyboard integration
  • Does not include month/year dropdown. This will be a separate PR.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label May 24, 2021
@github-actions github-actions bot added the package: vue @ionic/vue package label May 24, 2021
@liamdebeasi liamdebeasi merged commit 73de467 into next-datetime May 24, 2021
@liamdebeasi liamdebeasi deleted the datetime-time branch May 24, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant