Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): years displayed now more consistent with v5 datetime, max and min are now accounted for in MD mode #23616

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jul 13, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23615

What is the new behavior?

  • Max/Min are now accounted for when generating years in MD mode
  • Out of bounds years are no longer shown in MD mode, making behavior more consistent with iOS mode
  • Datetime renders max year as current year and min year as current year - 100 by default for better consistency with old datetime behavior.
  • I also changed the internals so that the years array is passed into the ios and MD functions so something like this doesn't happen again

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the base branch from master to next July 13, 2021 14:17
@github-actions github-actions bot added the package: core @ionic/core package label Jul 13, 2021
@liamdebeasi liamdebeasi changed the title fix(datetime): max and min are now accounted for in year picker for MD mode fix(datetime): years displayed now more consistent with v5 datetime, max and min are now accounted for in MD mode Jul 13, 2021
Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-datetime not listing all possible years (v6)
2 participants