Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action-sheet): add data property to ActionSheetButton #23744

Merged
merged 3 commits into from
Aug 9, 2021
Merged

feat(action-sheet): add data property to ActionSheetButton #23744

merged 3 commits into from
Aug 9, 2021

Conversation

EinfachHans
Copy link
Contributor

closes #23700

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #23700

What is the new behavior?

  • data added to ActionSheet Button Interface
  • Use button.data in buttonClick instead of undefined which is the same if the user doesn't enters a data

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Aug 9, 2021
@liamdebeasi liamdebeasi changed the title feat(action-sheet): expose 'data' in button props feat(action-sheet): add data property to ActionSheetButton Aug 9, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@liamdebeasi liamdebeasi merged commit 30f8508 into ionic-team:next Aug 9, 2021
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

@EinfachHans EinfachHans deleted the issue/23700 branch August 9, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants