Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform): add ability to override platform detection methods #23915

Merged
merged 7 commits into from
Sep 14, 2021
Merged

feat(platform): add ability to override platform detection methods #23915

merged 7 commits into from
Sep 14, 2021

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Sep 11, 2021 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #19737

What is the new behavior?

  • Default platform detection methods can now be overridden by a custom implementation.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: core @ionic/core package package: react @ionic/react package labels Sep 11, 2021
@willmartian willmartian marked this pull request as ready for review September 13, 2021 05:05
liamdebeasi
liamdebeasi suggested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, but we do need to add tests to verify this works. Additionally, we need to update the Config docs in the ionic-docs repo to show usage, the PlatformDetectionConfig interface, etc.

core/src/utils/config.ts Outdated Show resolved Hide resolved
@willmartian willmartian mentioned this pull request Sep 14, 2021
Merged
@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package labels Sep 14, 2021
liamdebeasi
liamdebeasi approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this!

@willmartian willmartian merged commit 45cabae into next Sep 14, 2021
@willmartian willmartian deleted the FW-63 branch September 14, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willmartian @liamdebeasi