Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add support for custom elements build #24077

Closed
wants to merge 16 commits into from
Closed

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Oct 14, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Prereqs:

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package labels Oct 14, 2021
@willmartian
Copy link
Contributor Author

Blocked on lazy loading Ionicons SVGs while using the CE build. Closing until this is addressed.

@GeorgeDigital
Copy link

Hi. Any News for custom element builds in angular? Would be very nice if this works also in angular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants