Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add event for when overlay is dismissed #24099

Merged
merged 5 commits into from
Dec 14, 2021
Merged

feat(select): add event for when overlay is dismissed #24099

merged 5 commits into from
Dec 14, 2021

Conversation

EinfachHans
Copy link
Contributor

@EinfachHans EinfachHans commented Oct 20, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #24088

What is the new behavior?

  • New Event ionDismiss is emitted when the created overlay is dismissed

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Oct 20, 2021
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've left a couple comments below. I also wanted to give you a heads up that Ionic is in a feature freeze until the release of v6, so this won't be merged until then.

core/src/components/select/select.tsx Outdated Show resolved Hide resolved
core/src/components/select/select.tsx Outdated Show resolved Hide resolved
@EinfachHans
Copy link
Contributor Author

@amandaesmith3 I have done your requests 😊 Yeah i totaly understand the feature freeze and having this first in v6 is not a problem for me

@EinfachHans EinfachHans changed the title feat(select): add event for when overlay is closed feat(select): add event for when overlay is dismissed Oct 26, 2021
@averyjohnston averyjohnston dismissed their stale review October 26, 2021 13:59

This looks good now 👍 We'll merge it after Ionic 6 has released. Thanks for your work!

@averyjohnston averyjohnston requested a review from a team as a code owner December 14, 2021 14:29
@averyjohnston averyjohnston merged commit c1ecf94 into ionic-team:main Dec 14, 2021
averyjohnston added a commit that referenced this pull request Dec 14, 2021
@averyjohnston
Copy link
Contributor

Reverting so changes can be pushed to a feature branch instead. Will open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants