-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): add event for when overlay is dismissed #24099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I've left a couple comments below. I also wanted to give you a heads up that Ionic is in a feature freeze until the release of v6, so this won't be merged until then.
@amandaesmith3 I have done your requests 😊 Yeah i totaly understand the feature freeze and having this first in v6 is not a problem for me |
This looks good now 👍 We'll merge it after Ionic 6 has released. Thanks for your work!
This reverts commit c1ecf94.
Reverting so changes can be pushed to a feature branch instead. Will open a new PR. |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #24088
What is the new behavior?
ionDismiss
is emitted when the created overlay is dismissedDoes this introduce a breaking change?
Other information