Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): Ionic components that use child Ionic components are now correctly defined #24191

Merged
merged 9 commits into from
Nov 11, 2021

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Nov 9, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23571, #24116, #24129

What is the new behavior?

  • Ionic components will now auto define any dependent components used in their shadow DOM. For example, ion-select will now define ion-select-popover in the custom elements registry. This allows developers to only worry about importing top level components without worry what they render.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 9, 2021
@willmartian willmartian changed the title Auto define ce feat(core): auto define custom elements Nov 9, 2021
@willmartian willmartian marked this pull request as ready for review November 11, 2021 15:33
@liamdebeasi liamdebeasi changed the title feat(core): auto define custom elements fix(all): Ionic components that use child Ionic components are now correctly defined Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants