Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): card modal shadow now shows up correctly on ipad #24203

Merged
merged 8 commits into from
Nov 11, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 11, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

With the new inline modals, we need to make sure that subsequent modals do not have a boxshadow/backdrop shown otherwise the screen will get progressively darker. This rule should only apply to non-card and non-sheet modals, but the selector was a bit too broad. The end result was boxshadows were hidden on all card modals on iPad.

Also there was a box shadow being applied to both the wrapper and shadow element which made the shadow appear to stack.

We did not have visual regression tests for these kinds of stacked modals, so this issue slipped through.

What is the new behavior?

  • Shadows are now shown correctly on the card modal on iPad.
  • Removed double box shadow.
  • Added visual regression tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 11, 2021
@liamdebeasi liamdebeasi changed the title fix(modal): card modal now shows up correctly on ipad fix(modal): card modal shadow now shows up correctly on ipad Nov 11, 2021
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

Base automatically changed from modal-radius to next November 11, 2021 15:01
@liamdebeasi liamdebeasi merged commit 5d4f5af into next Nov 11, 2021
@liamdebeasi liamdebeasi deleted the card-shadow branch November 11, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants