fix(modal): card modal shadow now shows up correctly on ipad #24203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
With the new inline modals, we need to make sure that subsequent modals do not have a boxshadow/backdrop shown otherwise the screen will get progressively darker. This rule should only apply to non-card and non-sheet modals, but the selector was a bit too broad. The end result was boxshadows were hidden on all card modals on iPad.
Also there was a box shadow being applied to both the wrapper and shadow element which made the shadow appear to stack.
We did not have visual regression tests for these kinds of stacked modals, so this issue slipped through.
What is the new behavior?
Does this introduce a breaking change?
Other information