Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): safari 15 webkit text alignment issue with input type date #24213

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Nov 12, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Date inputs on Safari 15 are center aligning text contents. This is due to a change in the appearance of input[type="date"] in Safari, that isn't aligned with the previous design considerations of ion-input.

Screen Shot 2021-11-11 at 9 51 55 PM

Issue Number: #24197

What is the new behavior?

Text alignment of input[type="date"] pseudo element aligns left on LTR and right on RTL; only when used inside of ion-input.

Screen Shot 2021-11-11 at 9 49 22 PM

Does this introduce a breaking change?

  • Yes
  • No

Other information

Repo used to replicate/isolate the bug: https://github.com/sean-perkins/24197-date-input-center

Likely this same issue should be resolved in Ionic 5.*.

@github-actions github-actions bot added the package: core @ionic/core package label Nov 12, 2021
@sean-perkins sean-perkins changed the title fix(input): webkit text alignment issue with date type fix(input): safari 15 webkit text alignment issue with input type date Nov 12, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's make sure we are following the commit guidelines when merging: https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#subject

Maybe something like:

fix(input): date type in ion-input now aligns correctly on ios 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants