Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): counter defaults to false to make upgrade easier #24263

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 23, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: See internal ticket. We received feedback from users that counter defaulting to true was interfering with custom validation and making the upgrade process painful. After discussing with the team, we decided that having counter default to false would be better for the upgrade process.

What is the new behavior?

  • Counter property now defaults to false

All of the tests that required counter already had counter="true" so I didn't need to change anything there.

Does this introduce a breaking change?

  • Yes
  • No
    Note: This is a breaking change from one pre-release to the next so it will not show up in the BREAKING.md guide.

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 23, 2021
Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants