fix(item): counter defaults to false to make upgrade easier #24263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: See internal ticket. We received feedback from users that
counter
defaulting totrue
was interfering with custom validation and making the upgrade process painful. After discussing with the team, we decided that havingcounter
default tofalse
would be better for the upgrade process.What is the new behavior?
false
All of the tests that required counter already had
counter="true"
so I didn't need to change anything there.Does this introduce a breaking change?
Note: This is a breaking change from one pre-release to the next so it will not show up in the
BREAKING.md
guide.Other information