chore(deps): update puppeteer to v10 #24342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaskiewicz
reviewed
Dec 8, 2021
averyjohnston
approved these changes
Dec 8, 2021
liamdebeasi
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
CI issues with M1 Macs and < v8 of puppeteer.
Issue Number: N/A (Internal Infrastructure)
What is the new behavior?
Updates dependencies for puppeteer and dependents (axe-core) to v10.
Does this introduce a breaking change?
Other information
There are multiple components in our system that make use of nested-interactive controls. Due to the complexity of these decisions to account for platform restrictions with accessibility, I've disabled that rule set for the two tests that fail as a result.
The rule was introduced in the 4.2 ruleset, before these components were architected. They are valid warnings that we will evaluate against platform changes.