Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): allow arrow configuration with controller approach #24512

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

You are unable to turn off the arrow when using the controller approach for displaying a popover.

Issue Number: Resolves #24487

What is the new behavior?

You can specify to disable the arrow from displaying when displaying a popover with the controller approach:

.create({
  component: ExampleComponent,
  arrow: false
});

Does this introduce a breaking change?

  • Yes
  • No

Other information

Technically this is supported today, if you type cast on top of the .create props type signature. This PR corrects the missing type configuration.

@sean-perkins sean-perkins requested a review from a team as a code owner January 5, 2022 04:05
@github-actions github-actions bot added the package: core @ionic/core package label Jan 5, 2022
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the interface docs: https://github.com/ionic-team/ionic-framework/tree/main/core/src/components/popover#interfaces

Once complete, this is good to merge.

Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 👍

@sean-perkins sean-perkins merged commit b39003a into main Jan 5, 2022
@sean-perkins sean-perkins deleted the FW-454 branch January 5, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: PopoverOptions interface lacks arrow attribute
3 participants