fix(modal): re-enable swipe gestures when modal is dismissed

[sean-perkins]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

When a modal is opened, the .show-modal class is applied. This class prevents the gesture for opening ion-menu. The class is never removed when a modal is dismissed, so when the modal is closed, users are unable to open menus through swipe gestures.

Issue URL: #24817

What is the new behavior?

When the modal is dismissed, the .show-modal class is removed from the host element. This allows the menu to be opened through a swipe gesture when the modal is dismissed.

Does this introduce a breaking change?

• Yes
• No

Other information

Confirmed in the reproduction app with dev build 6.0.10-dev.1645727760.16b0a89.

[liamdebeasi]

Code looks good, but we should add a test if we can. I know this only happens with gestures + Puppeteer and gestures are flaky so we might need to loop back to this in the future.

[sean-perkins]

Code looks good, but we should add a test if we can. I know this only happens with gestures + Puppeteer and gestures are flaky so we might need to loop back to this in the future.

Sounds good, happy to take a stab at it and see if there's an approach that isn't as flaky.

Also, the reporter confirmed the behavior is resolved in their app: #24817 (comment) 👍