Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): time picker now scrolls to correct value #24879

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 4, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #24878

The problem is that scrollActiveItemIntoView is called before isColumnVisible is set to true: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/picker-column-internal/picker-column-internal.tsx#L100

This did not used to be a problem, but with the introduction of the isColumnVisible check in https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/picker-column-internal/picker-column-internal.tsx#L152, this caused the initial scroll to no longer happen.

What is the new behavior?

  • Moved isColumnVisible to be set to true before calling the scroll operation.

Does this introduce a breaking change?

  • Yes
  • No

Other information

I opted not to add a new test as we do already have a test for this, but the test suite that checks is not working. I am working on fixing the test suite with my Playwright migration.

@liamdebeasi liamdebeasi requested a review from a team as a code owner March 4, 2022 14:30
@github-actions github-actions bot added the package: core @ionic/core package label Mar 4, 2022
@sean-perkins sean-perkins self-requested a review March 4, 2022 16:00
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: initial value in ion-datetime with "time" presentation not shown
3 participants