fix(angular): ngOnDestroy runs inside angular zone

[sean-perkins]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

When using ion-router-outlet, the page components will execute ngOnDestroy life cycle hooks outside of the Angular zone.

Issue URL: #22571

What is the new behavior?

• ngOnDestroy will execute inside of Angular zones when pages are unmounted inside ion-router-outlet

Does this introduce a breaking change?

• Yes
• No

Other information

[liamdebeasi]

Looks good! ionViewWillLeave and ionViewDidLeave still fire inside of NgZone, correct?

[sean-perkins]

Looks good! ionViewWillLeave and ionViewDidLeave still fire inside of NgZone, correct?

Correct! This change only effects the internal life cycle methods handled by Angular when a component is destroyed (ngOnDestroy). All life cycle methods (Angular & Ionic's custom) should run inside of an NgZone.