Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datetime): simpler way of accounting for time zone offsets in getToday #25132

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 14, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

  • Simplifies getToday by just passing the current minutes + the time zone offset to setMinutes.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner April 14, 2022 23:29
@liamdebeasi liamdebeasi changed the title refactor(datetime): simpler way of doing timezone offsets refactor(datetime): simpler way of accounting for timezone offsets in getToday Apr 14, 2022
@github-actions github-actions bot added the package: core @ionic/core package label Apr 14, 2022
@liamdebeasi liamdebeasi changed the title refactor(datetime): simpler way of accounting for timezone offsets in getToday refactor(datetime): simpler way of accounting for time zone offsets in getToday Apr 14, 2022
@liamdebeasi liamdebeasi merged commit 46cd483 into main Apr 15, 2022
@liamdebeasi liamdebeasi deleted the tz-offset branch April 15, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant