Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refresher): attach scroll listener to custom scroll target #25335

Merged
merged 16 commits into from
May 24, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Test migrations

What is the current behavior?

  • The ion-refresher usage with custom scroll target does not attach to the correct scroll container
  • The pull to refresh tests are written in Puppeteer and don't function correctly for the custom scroll target behavior

Issue URL: #25318

What is the new behavior?

  • Attaches the scroll behavior for ion-refresher to the specified custom scroll target
  • Migrates refresher tests to Playwright
  • Adds additional options to page.goto to support Playwright API
  • Exports the function to extend the page fixture, so it can be used when creating new browser contexts (for video recording within Playwright)

Does this introduce a breaking change?

  • Yes
  • No

Other information

This PR also removes the unnecessary screenshot tests (they did not capture anything relevant to ion-refresher). A follow-up PR will work to introduce screenshot tests for the native & legacy refresher appearances.

Dev-build: 6.1.7-dev.11653327570.1759e1d5

@sean-perkins sean-perkins requested a review from a team as a code owner May 23, 2022 18:01
@github-actions github-actions bot added the package: core @ionic/core package label May 23, 2022
core/src/components/refresher/test/test.utils.ts Outdated Show resolved Hide resolved
core/src/components/refresher/refresher.tsx Outdated Show resolved Hide resolved
core/src/utils/test/playwright/playwright-page.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants