Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): router compatibility with Angular 12/13 #25456

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

In 6.1.9 we shipped a change to the router to support Angular 14. In routing scenarios where the component is injected into the root ion-router-outlet, the component factory resolver instance is null and causes the routing logic to fallback to the new Angular 14 behavior.

This results in routing throwing an exception and not routing the user/rendering the view.

Issue URL: #25448

What is the new behavior?

  • Re-adds the fallback to the router outlet's component factory resolver when the supplied value is unset
  • Angular 12/13 applications can route to root routes in an ion-router-outlet.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.1.10-dev.11654882801.1eb62ed9

@sean-perkins sean-perkins requested a review from a team as a code owner June 13, 2022 14:45
@github-actions github-actions bot added the package: angular @ionic/angular package label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants