Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datetime-button): add selecting interaction support #25620

Merged
merged 24 commits into from
Jul 14, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jul 12, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: Internal ticket

What is the new behavior?

  • Adds support for selecting either the date/time button and reflecting that selection by highlighting the button text
  • Datetime button can now link with a datetime instance
  • Datetime button now renders the localized date and time according to the value of datetime.
  • Adds tests

Does this introduce a breaking change?

  • Yes
  • No

Other information

There are a few things that will be addressed separately:

  • The overlays are not correctly sized
  • preferWheel is not fully supported with the combined date/time wheel picker
  • Visual regression tests
  • Disabling buttons, customizing buttons, etc

@github-actions github-actions bot added the package: core @ionic/core package label Jul 12, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review July 12, 2022 20:21
@liamdebeasi liamdebeasi requested a review from a team as a code owner July 12, 2022 20:21
@averyjohnston
Copy link
Contributor

There seems to be something wonky with the time display; if I pick a different date, the displayed hour changes but the selected one in the wheel picker doesn't: https://user-images.githubusercontent.com/90629384/178825253-7d164e5c-8505-4b40-b439-9f0065248bad.mp4

Base automatically changed from 546-styles to FW-546 July 14, 2022 14:25
@liamdebeasi liamdebeasi merged commit 8387ba3 into FW-546 Jul 14, 2022
@liamdebeasi liamdebeasi deleted the 546-text branch July 14, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants