-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datetime-button): add support for custom, disabled, and accessible buttons #25622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c6e594b.
sean-perkins
approved these changes
Jul 12, 2022
core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts
Show resolved
Hide resolved
averyjohnston
suggested changes
Jul 18, 2022
core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts
Outdated
Show resolved
Hide resolved
core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts
Outdated
Show resolved
Hide resolved
averyjohnston
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: Internal ticket
What is the new behavior?
<button>
element is never overridden. This means that developers:a) Do not need to provide a custom button (reduces boilerplate)
b) Still get accessible buttons with
aria-expanded
. If they provided their own buttons they would need to do that themselves.Does this introduce a breaking change?
Other information