Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datetime-button): add support for custom, disabled, and accessible buttons #25622

Merged
merged 28 commits into from
Jul 19, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: Internal ticket

What is the new behavior?

  • Added a "native" shadow part to allow developers to customize the native button elements inside the shadow dom.
  • Added ripple effect to buttons on MD mode
  • Refactored the architecture of the buttons so that the <button> element is never overridden. This means that developers:
    a) Do not need to provide a custom button (reduces boilerplate)
    b) Still get accessible buttons with aria-expanded. If they provided their own buttons they would need to do that themselves.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jul 12, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review July 12, 2022 20:21
@liamdebeasi liamdebeasi requested a review from a team as a code owner July 12, 2022 20:21
Base automatically changed from 546-text to FW-546 July 14, 2022 14:55
@liamdebeasi liamdebeasi merged commit b5403d1 into FW-546 Jul 19, 2022
@liamdebeasi liamdebeasi deleted the 546-disabled branch July 19, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants