Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-bar): use correct import path #25898

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

corysmc
Copy link
Contributor

@corysmc corysmc commented Sep 8, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When running a stencil application with the latest @ionic/[email protected] the ion-tab-bar component has an unresolved import:

Bundling Warning UNRESOLVED_IMPORT '@utils/keyboard/keyboard-controller' is imported by ./node_modules/@ionic/core/dist/collection/components/tab-bar/tab-bar.js, but could not be resolved – treating it as an external dependency

Issue URL: #25897

What is the new behavior?

Now importing via relative path - which is what the rest of the codebase does.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@corysmc corysmc requested a review from a team as a code owner September 8, 2022 06:19
@github-actions github-actions bot added the package: core @ionic/core package label Sep 8, 2022
@corysmc corysmc changed the title fix()Update tab-bar.tsx fix(ion-tab-bar): Use relative imports Sep 8, 2022
@liamdebeasi liamdebeasi changed the title fix(ion-tab-bar): Use relative imports fix(tab-bar): use correct import path Sep 8, 2022
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants