Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datetime): account for 12AM with min times and 12 hour format #25952

Merged
merged 10 commits into from
Sep 19, 2022
Merged

fix(datetime): account for 12AM with min times and 12 hour format #25952

merged 10 commits into from
Sep 19, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 16, 2022 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25183

What is the new behavior?

  • Internal utils now use "0" as "12am" instead of "12" when doing min/max comparisons.
  • Some of the util tests were also wrong, so I fixed those too.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Sep 16, 2022
@liamdebeasi liamdebeasi changed the title Fw 1458 fix(datetime): calculate minimum times correctly Sep 16, 2022
@liamdebeasi liamdebeasi changed the title fix(datetime): calculate minimum times correctly fix(datetime): account for midnight with min times Sep 16, 2022
@liamdebeasi liamdebeasi changed the title fix(datetime): account for midnight with min times fix(datetime): account for 12AM with min times and 12 hour format Sep 16, 2022
liamdebeasi
liamdebeasi commented Sep 16, 2022
View reviewed changes
core/src/components/datetime/utils/format.ts
*/
export const getFormattedHour = (hour: number, use24Hour: boolean): string => {
if (!use24Hour) {
return hour.toString();
if (use24Hour) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I flipped the order around so that we check positive cases first (IMO I think the function is easier to understand as a result)

@liamdebeasi liamdebeasi marked this pull request as ready for review September 16, 2022 15:59
@liamdebeasi liamdebeasi requested a review from a team as a code owner September 16, 2022 15:59
@liamdebeasi liamdebeasi merged commit 55ebd6c into main Sep 19, 2022
@liamdebeasi liamdebeasi mentioned this pull request Sep 19, 2022
Closed
7 tasks
@liamdebeasi liamdebeasi deleted the FW-1458 branch September 19, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-perkins sean-perkins sean-perkins approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Minimum date in Datetime causes issues with 12-hour clock
2 participants
@liamdebeasi @sean-perkins