-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input): add labelPlacement #26206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sean Perkins <[email protected]>
This reverts commit 0dceaf6.
averyjohnston
suggested changes
Nov 4, 2022
averyjohnston
approved these changes
Nov 4, 2022
sean-perkins
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: N/A
With the new input control, developers need a way of placing the label similar to how they could using position on
ion-label
.What is the new behavior?
position
property onion-label
. start and end should have similar behavior asslot
onion-item
(though may look slightly different due to ion-input not having a bottom border by default).ion-item
(56px for MD and 44px for iOS). I added min-heights toion-input
so inputs would have the correct dimensions even when used outside ofion-item
.Note: The
--padding-*
variables have been revised in this PR. These variables were originally needed so that the correct padding was set when used inside ofion-item
asion-item
adds its own padding. Now that inputs can be used outside ofion-item
the padding was no longer needed so I set these to 0. The new ion-input syntax should have no opinions about spacing around the input to allow developers more flexibility in how to use these inputs (in a list, in a grid, etc). Additionally, the padding now targets the element that wraps the label and the input instead of just the input.Does this introduce a breaking change?
Other information