Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): scrollbars are visible with overflow #26284

Merged
merged 8 commits into from
Nov 15, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

A textarea with overflow does not display scrollbars to the user. This makes it difficult for users to access overflowed content in a textarea that isn't using auto grow.

Issue URL: #26278

What is the new behavior?

  • Overflow hidden only applies to auto grow textarea (where the contents will grow in height, resulting in no overflow)
  • Scrollbars are visible for a textarea with overflow

Does this introduce a breaking change?

  • Yes
  • No

Other information

Capturing scrollbars in Playwright would be flaky, so test coverage is skipped for this PR.

Dev-build: 6.3.7-dev.11668447091.1afa4f71

@github-actions github-actions bot added the package: core @ionic/core package label Nov 14, 2022
@sean-perkins sean-perkins marked this pull request as ready for review November 14, 2022 18:40
@sean-perkins sean-perkins requested a review from a team as a code owner November 14, 2022 18:40
@sean-perkins sean-perkins merged commit 7a990ff into main Nov 15, 2022
@sean-perkins sean-perkins deleted the FW-2811 branch November 15, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants