fix(item): inherit aria attributes before render #26546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The
aria-label
attribute is not reflected correctly withion-item
and Vue.There are two contributing factors:
@stencil/vue-output-target
does not pass aria attributes from the Vue component host to the web component host.raf
callback inside thecomponentDidLoad
lifecycle would not reflect attributes correctly when rendering a link or button inion-item
.Issue URL: #26538
What is the new behavior?
aria-label
reflects from theion-item
to the.item-native
element in VueDoes this introduce a breaking change?
Other information
Note: Dependent on ionic-team/stencil-ds-output-targets#316 merging and a new build of the
@stencil/vue-output-target
.Dev-build:
6.4.2-dev.11672338764.1def15a7