Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fab-button): icon is not announced by screen readers #26619

Merged
merged 4 commits into from
Jan 19, 2023
Merged

fix(fab-button): icon is not announced by screen readers #26619

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4038a3d
fix(fab-button): icon is not announced by screen readers
liamdebeasi Jan 17, 2023
71aa92a
chore(): lint
liamdebeasi Jan 17, 2023
25215d4
Merge branch 'main' into FW-2106
liamdebeasi Jan 17, 2023
3d583ee
Merge branch 'main' into FW-2106
liamdebeasi Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/components/fab-button/fab-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,13 @@ export class FabButton implements ComponentInterface, AnchorInterface, ButtonInt
onClick={(ev: Event) => openURL(href, ev, this.routerDirection, this.routerAnimation)}
{...inheritedAttributes}
>
<ion-icon icon={this.closeIcon} part="close-icon" class="close-icon" lazy={false}></ion-icon>
<ion-icon
aria-hidden="true"
icon={this.closeIcon}
part="close-icon"
class="close-icon"
lazy={false}
></ion-icon>
<span class="button-inner">
<slot></slot>
</span>
Expand Down