fix(input, textarea): show error state after touch #26940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
commented
Mar 9, 2023
Comment on lines
-292
to
-299
| :host(.ion-touched.ion-invalid) { | ||
| --highlight-color: var(--highlight-color-invalid); | ||
| } | ||
|
|
||
| :host(.ion-touched.ion-valid) { | ||
| --highlight-color: var(--highlight-color-valid); | ||
| } | ||
|
|
There was a problem hiding this comment.
This was duplicate code
liamdebeasi
commented
Mar 9, 2023
Comment on lines
-401
to
-411
| // Input Highlight | ||
| // ---------------------------------------------------------------- | ||
|
|
||
| :host(.ion-touched.ion-invalid) { | ||
| --highlight-color: var(--highlight-color-invalid); | ||
| } | ||
|
|
||
| :host(.ion-touched.ion-valid) { | ||
| --highlight-color: var(--highlight-color-valid); | ||
| } | ||
|
|
There was a problem hiding this comment.
This was duplicate code
sean-perkins
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Changes look good.
The test templates (e.g. test/bottom-content/index.html) are a little confusing to reason about right now, unless you are aware of the extra classes that need to be appended to the host to make the error slot visible and/or the styling. Should we add a minimal implementation here with a button that adds the required classes to help with manually testing?
|
Good catch! I updated those templates so |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #26939, resolves #21643
There are a couple issues with the form validation highlighting:
Form validation highlighting is used to indicate that the user did something right/wrong, so having these states always show can be confusing.
What is the new behavior?
I updated the behavior as per the following table:
Reasoning for invalid state changes: An invalid state indicates the user entered malformed/incorrect data. As a result, having the invalid state show before the user has even interacted with the input can be confusing for the user. We show the input regardless of focus state once it has been touched. This is because users may need to correct data in order to submit a form. Showing the invalid highlight on both focus and blur lets users quickly identify which form controls need fixing.
Reasoning for the valid changes: A valid state indicates that the user entered correct data. As a result, we should give them that positive feedback as soon as their data is valid. We also show the valid state regardless of touched state because some forms may pre-populate data. Users may not necessarily want to change that pre-populated data if it is valid. Additionally, the user does not need to always know that an input is valid which is why we only show it on focus. This behavior also aligns with the behavior found in Ionic 6.
Does this introduce a breaking change?
Other information
Dev build: 7.0.0-dev.11678373650.1975657a