Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toast): add htmlAttributes property for passing attributes to buttons #27855

Merged
merged 7 commits into from
Jul 31, 2023
Merged

feat(toast): add htmlAttributes property for passing attributes to buttons #27855

merged 7 commits into from
Jul 31, 2023

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jul 25, 2023 •
edited
Loading

Issue number: N/A

What is the current behavior?

Buttons containing only icons are not accessible as there is no way to pass an aria-label attribute (or any other html attribute).

What is the new behavior?

  • Adds the htmlAttributes property on the ToastButton interface
  • Passes the htmlAttributes to the buttons
  • Adds a test to verify aria-label and aria-labelled-by are passed to the button

Does this introduce a breaking change?

  • Yes
  • No

@stackblitz
Copy link

stackblitz bot commented Jul 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jul 25, 2023
@brandyscarney brandyscarney changed the base branch from main to feature-7.3 July 26, 2023 21:12
@brandyscarney brandyscarney marked this pull request as ready for review July 27, 2023 15:18
@brandyscarney brandyscarney requested review from a team and thetaPC and removed request for a team July 27, 2023 16:05
@brandyscarney brandyscarney mentioned this pull request Jul 27, 2023
Merged
thetaPC
thetaPC approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit 9a68588 into feature-7.3 Jul 31, 2023
43 checks passed
@brandyscarney brandyscarney deleted the FW-4240-toast branch July 31, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@thetaPC thetaPC thetaPC approved these changes

@sean-perkins sean-perkins sean-perkins approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandyscarney @liamdebeasi @thetaPC @sean-perkins