fix(angular): popover arrow navigation with disabled items #29662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29640
What is the current behavior?
(Angular) If a list inside of a popover contains a disabled item and is included in the following way:
when you try to navigate using the arrow down keys, it will stop at the disabled item instead of continuing over it.
Note that changing the item to the following will work:
What is the new behavior?
Reflect the
disabled
property in the item so that when items are queried in the popover, the arrow down key skips over the disabled item.Does this introduce a breaking change?
Other information
This can be tested in the Angular test app by following the documentation here: https://github.com/ionic-team/ionic-framework/blob/main/docs/angular/testing.md
Removing my fix in
core
, then runningnpm run build
and re-syncing the test app should reproduce the problem.