chore(deps): update dependency @stencil/core to v4.19.0 #29666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
added a commit
that referenced
this pull request
Jun 27, 2024
…e to 4.19.1 in core (#29670) Issue number: internal --------- This does a couple things: **1 - Adds a `sync` command to get the latest `core` build in `angular-server`** The release process for `angular-server` failed [here](https://github.com/ionic-team/ionic-framework/actions/runs/9686982182/job/26730689874). This failure was only made apparent because the Lerna command [here](https://github.com/ionic-team/ionic-framework/blob/52ff0505e86dc204cb2fd2fdaf67229e6eeb36f8/.github/workflows/actions/publish-npm/action.yml#L35) runs prior to building each package. This should have been caught by CI on the [update to @stencil/core to v4.19.0](#29666), but the `angular-server` package is the only package that doesn't sync `core` before it builds. This PR adds a `sync` command so that `angular-server` will use the latest core build during the normal build action. **2 - Resolving types errors in `angular-server`** After properly syncing `core` in `angular-server` using the command added, running build fails with the following: <img width="400px" alt="Screenshot 2024-06-27 at 1 16 15 PM" src="https://github.com/ionic-team/ionic-framework/assets/6577830/68d74750-821b-4776-b563-124d8fa06a79"> This was a regression in Stencil. `@stencil/core` has been updated to resolve these errors so the build passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
ionic-team/stencil (@stencil/core)
v4.19.0Compare Source
Bug Fixes
Features
toHaveLastReceivedEventDetailevent spy matcher (#5829) (63491de), closes #2488