Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): allow custom roles and aria attributes to be set on content #29753

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

brandyscarney
Copy link
Member

Issue number: N/A


What is the current behavior?

Setting a custom role on the ion-content element does not work.

What is the new behavior?

  • Inherit attributes for the content element which allows a custom role property to be set
  • Adds e2e tests for content, header, and footer verifying that the proper roles are assigned

Does this introduce a breaking change?

  • Yes
  • No

Other information

To test this PR:

  1. Switch to the branch and navigate to the core/ directory
  2. Make sure to run npx playwright install if it has not been updated recenly
  3. Run npm run test.e2e src/components/content/test/a11y/
  4. Verify that the tests pass
  5. Remove my fix in core/src/components/content/content.tsx and run the test again
  6. Verify that the should allow for custom role tests fail

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 5:40pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 6, 2024
@brandyscarney brandyscarney marked this pull request as ready for review August 6, 2024 16:33
@brandyscarney brandyscarney requested a review from a team as a code owner August 6, 2024 16:33
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just realized that there's no issue related to this. So disregard my previous request.

@brandyscarney brandyscarney added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 7b16397 Aug 7, 2024
48 checks passed
@brandyscarney brandyscarney deleted the ROU-10932 branch August 7, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants