Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viewcontroller): adds onWillDismiss callback (0 delay) #7060

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Jun 26, 2016

Short description of what this resolves:

#6702

Changes proposed in this pull request:

  • Adds a new onWillDismiss callback that is called before the animation begins. (it has the same signature than onDismiss)

Ionic Version: 2.x

Fixes: #6702

@adamdbradley
Copy link
Contributor

While we're at it, we should rename onDismiss to onDidDismiss to have the same pattern as our lifecycle events. And if we are going to do that, we can deprecate onDismiss and have it still work, but print a console.warn() to use onDidDismiss.

@manucorporat
Copy link
Contributor Author

@adamdbradley I totally agree with you. Tomorrow I update the PR!

@adamdbradley adamdbradley merged commit ec99bfd into ionic-team:master Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants