Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(itemReorder): animate reorder button #7651

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

mhartington
Copy link
Contributor

Short description of what this resolves:

adds the ability to animate the reorder button.

Ionic Version: 1.x / 2.x
2.x

@manucorporat manucorporat self-assigned this Aug 18, 2016
@manucorporat manucorporat merged commit 1f78487 into master Aug 20, 2016
@manucorporat manucorporat mentioned this pull request Aug 20, 2016
4 tasks
@manucorporat
Copy link
Contributor

@adam I just noticed how this PR works, it makes ion-reorder always "visible" but off screen which could have a negative performance effect in all lists. I will try to find a solution

manucorporat added a commit that referenced this pull request Aug 20, 2016
@adamdbradley adamdbradley deleted the feature/reorderAnimations branch August 26, 2016 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants